mesh-adaptation / goalie

Goal-oriented error estimation and mesh adaptation for finite element problems solved using Firedrake
Other
1 stars 1 forks source link

Delete demo on Solid body rotation with multiple prognostic variables #171

Closed ddundo closed 2 months ago

ddundo commented 2 months ago

I think that the solid_body_rotation_split.py demo is written in a non-goalie way, which became apparent when working on #169. For example, the way it's written would not allow us to extend it to a goal-oriented approach.

It's also a very very specific case where all PDEs are the same. So I'm not sure how useful it is in general, and may even be misleading/confusing. E.g. I think that adding the field kwarg to get_form may be quite confusing to new users.

I would either:

What do you think @jwallwork23?

jwallwork23 commented 2 months ago

Sure, feel free to delete it.