search

mesh-adaptation / goalie

Goal-oriented error estimation and mesh adaptation for finite element problems solved using Firedrake
Other
2 stars 0 forks source link

Extract solutions in a private method #178

Closed ddundo closed 5 months ago

ddundo commented 7 months ago

Closes #177. Partially addresses #142.

Also partially addresses #165 since it significantly simplifies MeshSeq.solve_forward and AdjointMeshSeq.solve_adjoint, and removes the current overlap in the code between them for extracting solutions.

ddundo commented 7 months ago

Sorry, had to fix a docstring in the last commit. I cancelled the workflow since it's just a docstring update and the previous workflow passed :)

ddundo commented 7 months ago

Before reviewing this, please take a look at #145. I'd rather close this PR and go with that idea :)