search

mesh-adaptation / goalie

Goal-oriented error estimation and mesh adaptation for finite element problems solved using Firedrake
Other
1 stars 1 forks source link

Add `CITATION.cff` #194

Closed jwallwork23 closed 1 month ago

jwallwork23 commented 1 month ago

Closes #115.

Adds a citation file so that releases work nicely with Zenodo.

Reviewers: please check you are happy with how your names are presented, that your ORCIDs are correct and present (if you have one). Feel free to push directly to the branch if you have edits.

jwallwork23 commented 1 month ago

Thanks @jwallwork23! I added my ORCID and cancelled the workflow after seeing that the check_citation part passed.

I wonder if there's a way to configure the CI so that it won't run if the changes aren't code changes... maybe it's too much to ask.

ddundo commented 1 month ago

I wonder if there's a way to configure the CI so that it won't run if the changes aren't code changes... maybe it's too much to ask.

Well I previously suggested https://github.com/tj-actions/changed-files which could be used for this too :)

ddundo commented 1 month ago

Well I previously suggested https://github.com/tj-actions/changed-files which could be used for this too :)

I think this is fun so I'd be happy to open a PR with it and then you can feel free to reject it :) it's not a lot of work anyway

jwallwork23 commented 1 month ago

@acse-ej321 do you have an ORCID to add or can we merge this?

acse-ej321 commented 1 month ago

@jwallwork23 - I've gone ahead and registered with Orchid as you recommended and have added the number. Thanks for your patience.