Shorten demos during testing outside of original scripts

mesh-adaptation / goalie

Goal-oriented error estimation and mesh adaptation for finite element problems solved using Firedrake

Other

1 stars 1 forks source link

Shorten demos during testing outside of original scripts #199

Closed ddundo closed 1 month ago

ddundo commented 1 month ago

Closes #173. Closes #175.

This PR:

runs the demos directly in test_demos.py instead of using subprocess, so that demos contribute properly to the coverage report
modifies the demos inside test_demos.py to cut down run time, instead of exporting a global environment variable that is then used inside demos in an if statement

@jwallwork23 you said that we can take over issues without asking, so I hope you don't mind that I did :)

ddundo commented 1 month ago

It looks like the tape isn't cleared properly, since I don't get these 3 failing tests if I just run pytest test_mesh_seq.py. This issue hasn't been caught because demos were run in a subprocess so it didn't affect other tests. I think at least...

Actually the issue was that some demos had set_log_level(DEBUG) which spilled over to other tests. I fixed it by resetting the log level, which I think is fine - there should be no other spill-over from demos.