search

mesh-adaptation / goalie

Goal-oriented error estimation and mesh adaptation for finite element problems solved using Firedrake
Other
2 stars 0 forks source link

Compute error indicators after each subinterval #212

Closed ddundo closed 2 months ago

ddundo commented 2 months ago

Closes #209.

Similarly to MeshSeq._solve_forward and MeshSeq.solve_forward, this PR makes AdjointMeshSeq.solve_adjoint use a generator function AdjointMeshSeq._solve_adjoint that yields after each subinterval solve. That way we can compute error indicators in GoalOrientedMeshSeq.indicate_errors after each subinterval.

ddundo commented 2 months ago

@jwallwork23 could you please review (once you're back from the conference - no rush)? This passes locally for me with the outdated petsc version, so I think it's ready for review. But I won't merge before https://github.com/mesh-adaptation/animate/pull/142 is merged

jwallwork23 commented 2 months ago

I guess this needs to be rebased on top of main or have main merged into it to pick up the fix from #214.