search

mesh-adaptation / goalie

Goal-oriented error estimation and mesh adaptation for finite element problems solved using Firedrake
Other
1 stars 1 forks source link

Rework `enforce_element_constraints` #56

Closed jwallwork23 closed 4 months ago

jwallwork23 commented 11 months ago

Closes #12. See PR https://github.com/pyroteus/animate/pull/38.

Here we rename enforce_element_constraints as enforce_variable_constraints and make use of the new functionality in Animate.

Tests still need to be added.

jwallwork23 commented 5 months ago

Partially addresses #121.

jwallwork23 commented 5 months ago

Sorry @ddundo, I requested your review on this but then realised I hadn't added any tests for the new functionality. Will look into it and then get back to you.

jwallwork23 commented 5 months ago

Okay it's now ready for review @ddundo

jwallwork23 commented 5 months ago

Would you mind taking a look at this @ddundo? The changes should be fairly non-controversial.

jwallwork23 commented 5 months ago

Sorry @jwallwork23, I forgot about this! Looks good, but I had some tests fail locally so I re-ran the CI and got the same here.

I just merged in main so hopefully that fixes things.

ddundo commented 4 months ago

@jwallwork23 sorry, I don't know if you were waiting for a response from me here :) it looks good to me now!

jwallwork23 commented 4 months ago

@jwallwork23 sorry, I don't know if you were waiting for a response from me here :) it looks good to me now!

Please can you approve? Otherwise I can't merge.