search

mesh-adaptation / goalie

Goal-oriented error estimation and mesh adaptation for finite element problems solved using Firedrake
Other
1 stars 1 forks source link

Logic in mesh_sequence._output() #93

Open stephankramer opened 6 months ago

stephankramer commented 6 months ago

https://github.com/pyroteus/goalie/blob/8a9cd9b26027b2a9145146e27371dc584d34bec7/goalie/mesh_seq.py#L437C29-L437C29

Just a quick query: what is the rationale to allow _output() to return None if it can't find the output on the given block with the name it expects? Why is this allowed at all, and only in the steady case? As the comment says it relies on the user using the correct name in get_solver - but if they get it wrong there is no error (in the steady case).

jwallwork23 commented 5 months ago

Yeah you're right, this is probably wrong and at best misleading.