meshcat-dev / meshcat-python

WebGL-based 3D visualizer for Python
MIT License
258 stars 63 forks source link

Features: set captured image resolution, set camera target, set camera position #109

Closed ManifoldFR closed 1 year ago

ManifoldFR commented 2 years ago

This follows the PR https://github.com/rdeits/meshcat/pull/111. I expose the following new features from that PR:

Also:

codecov-commenter commented 2 years ago

Codecov Report

Base: 73.39% // Head: 72.29% // Decreases project coverage by -1.10% :warning:

Coverage data is based on head (41b5370) compared to base (cd04af4). Patch coverage: 34.37% of modified lines in pull request are covered.

:exclamation: Current head 41b5370 differs from pull request most recent head 6b2b9f2. Consider uploading reports for the commit 6b2b9f2 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #109 +/- ## ========================================== - Coverage 73.39% 72.29% -1.10% ========================================== Files 11 11 Lines 1075 1101 +26 ========================================== + Hits 789 796 +7 - Misses 286 305 +19 ``` | [Impacted Files](https://codecov.io/gh/rdeits/meshcat-python/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Robin+Deits) | Coverage Δ | | |---|---|---| | [src/meshcat/geometry.py](https://codecov.io/gh/rdeits/meshcat-python/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Robin+Deits#diff-c3JjL21lc2hjYXQvZ2VvbWV0cnkucHk=) | `88.96% <ø> (ø)` | | | [src/meshcat/servers/zmqserver.py](https://codecov.io/gh/rdeits/meshcat-python/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Robin+Deits#diff-c3JjL21lc2hjYXQvc2VydmVycy96bXFzZXJ2ZXIucHk=) | `28.89% <0.00%> (-0.34%)` | :arrow_down: | | [src/meshcat/visualizer.py](https://codecov.io/gh/rdeits/meshcat-python/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Robin+Deits#diff-c3JjL21lc2hjYXQvdmlzdWFsaXplci5weQ==) | `71.55% <35.71%> (-4.15%)` | :arrow_down: | | [src/meshcat/commands.py](https://codecov.io/gh/rdeits/meshcat-python/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Robin+Deits#diff-c3JjL21lc2hjYXQvY29tbWFuZHMucHk=) | `80.59% <40.00%> (-11.86%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Robin+Deits). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Robin+Deits)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ManifoldFR commented 2 years ago

Just rebased on master.

ManifoldFR commented 2 years ago

Did a clean rebase on master and updated demo.ipynb with examples of the camera pos/target options

Codecov still doesn't seem to like the commit however, maybe it doesn't look at the Jupyter notebook?

ManifoldFR commented 2 years ago

Hi @rdeits, sorry to be a bother, but do you think this PR is ready to be merged? We kind of let it marinate in open PR limbo (😅) but now with @jcarpent we're thinking about using the new features from this PR in a future release of Pinocchio

Should I work on the code coverage or is that OK?

Thanks !

rdeits commented 1 year ago

I'm embarrassed that it took me so long to get back to this, but I do really appreciate the contribution. I've verified that this works well locally, so let's do it!