Closed ManifoldFR closed 1 year ago
Base: 73.39% // Head: 72.29% // Decreases project coverage by -1.10%
:warning:
Coverage data is based on head (
41b5370
) compared to base (cd04af4
). Patch coverage: 34.37% of modified lines in pull request are covered.:exclamation: Current head 41b5370 differs from pull request most recent head 6b2b9f2. Consider uploading reports for the commit 6b2b9f2 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Just rebased on master.
Did a clean rebase on master and updated demo.ipynb
with examples of the camera pos/target options
Codecov still doesn't seem to like the commit however, maybe it doesn't look at the Jupyter notebook?
Hi @rdeits, sorry to be a bother, but do you think this PR is ready to be merged? We kind of let it marinate in open PR limbo (😅) but now with @jcarpent we're thinking about using the new features from this PR in a future release of Pinocchio
Should I work on the code coverage or is that OK?
Thanks !
I'm embarrassed that it took me so long to get back to this, but I do really appreciate the contribution. I've verified that this works well locally, so let's do it!
This follows the PR https://github.com/rdeits/meshcat/pull/111. I expose the following new features from that PR:
get_image()
resolutionAlso: