search

meshcat-dev / meshcat-python

WebGL-based 3D visualizer for Python
MIT License
259 stars 62 forks source link

Remove unused import from collections. #72

Closed RussTedrake closed 4 years ago

RussTedrake commented 4 years ago

It was triggering deprecation warnings on ubuntu focal: "Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working". and, it turns out, was not actually being used.

codecov-commenter commented 4 years ago

Codecov Report

Merging #72 into master will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   76.01%   75.98%   -0.03%     
==========================================
  Files          11       11              
  Lines        1013     1012       -1     
==========================================
- Hits          770      769       -1     
  Misses        243      243
Impacted Files Coverage Δ
src/meshcat/servers/zmqserver.py 33.05% <ø> (-0.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21c612e...ffe1c94. Read the comment docs.

RussTedrake commented 4 years ago

btw -- codecov, how can removing a line of code that was unused decrease the code coverage?

rdeits commented 4 years ago

Thanks!