meshcat-dev / meshcat

Remotely-controllable 3D viewer, built on top of three.js
MIT License
250 stars 44 forks source link

fix dat.GUI button elements layout #100

Closed RussTedrake closed 3 years ago

RussTedrake commented 3 years ago

without this fix, buttons added to the GUI with a long name were artificially truncated to the same length that a slider name gets truncated (to make room for the slider and text input). The button should not have that restriction.

After this fix, the complete long name of the button is displayed properly.

RussTedrake commented 3 years ago

FWIW, I've also gone ahead and PR'd the upstream fix. https://github.com/dataarts/dat.gui/pull/306 . If that goes through, then we can bump the dependency and get rid of the one-line bandaid. But I would like to land this for now.