search

meshcat-dev / meshcat

Remotely-controllable 3D viewer, built on top of three.js
MIT License
256 stars 48 forks source link

index.js: replace deprecated mergeBufferGeometries #159

Closed ManifoldFR closed 9 months ago

ManifoldFR commented 10 months ago

This PR fixes a deprecated function that was recently removed in ThreeJS.

jwnimmer-tri commented 9 months ago

Thanks for this! Apparently I don't have permission to push amendments atop this branch, so I'll need to ask you to do it:

(1) Please merge up (or rebase) to the latest master branch.

(2) Please re-generate the dist files. The Readme.md has instructions, e.g. if you have docker available you can do ./rebuild/rebuild.sh to re-generate the dist files.

ManifoldFR commented 9 months ago

Thanks for this! Apparently I don't have permission to push amendments atop this branch, so I'll need to ask you to do it:

(1) Please merge up (or rebase) to the latest master branch.

(2) Please re-generate the dist files. The Readme.md has instructions, e.g. if you have docker available you can do ./rebuild/rebuild.sh to re-generate the dist files.

Thanks, it is done. By the way, running the build npm script generated a main.dist.js.LICENSE.txt file - is this expected behaviour ?

jwnimmer-tri commented 9 months ago

By the way, running the build npm script generated a main.dist.js.LICENSE.txt file - is this expected behaviour?

Yes, and you were correct to not commit it. The webpack license plugin creates that file, but we don't need it so we don't commit it. I should probably mention this in Readme for clarity. I also see that I typo'd its filename in .gitignore which is why it's showing up; oops.

ManifoldFR commented 9 months ago

By the way, running the build npm script generated a main.dist.js.LICENSE.txt file - is this expected behaviour?

Yes, and you were correct to not commit it. The webpack license plugin creates that file, but we don't need it so we don't commit it. I should probably mention this in Readme for clarity. I also see that I typo'd its filename in .gitignore which is why it's showing up; oops.

I'll make a quick patch/PR for the typo, just noticed this when I was rebasing my other branches.

jwnimmer-tri commented 9 months ago

I'll make a quick patch/PR for the typo, just noticed this when I was rebasing my other branches.

Thanks!