Add webpack rebuild via Dockerfile

meshcat-dev / meshcat

Remotely-controllable 3D viewer, built on top of three.js

MIT License

250 stars 44 forks source link

Add webpack rebuild via Dockerfile #161

Closed jwnimmer-tri closed 8 months ago

jwnimmer-tri commented 8 months ago

This change is

jwnimmer-tri commented 8 months ago

+@SeanCurtis-TRI for feature review, please. I'm interested both in feedback on the idea itself, as well as the implementation.

jwnimmer-tri commented 8 months ago

Hopefully running it locally overwrote the dist files, but with identical content with what the used to be? The goal here is for the rebuild to be hermetic and idempotent, so if you're seeing different results than me, we should investigate.

jwnimmer-tri commented 8 months ago

Yup. My only concern is whether @sammy-tri also saw unmodified => no diffs.

(I'm not worried about the modified => diffs side of things; that seems sufficiently proven already.)

jwnimmer-tri commented 8 months ago

Tyvm!