meshcat-dev / meshcat

Remotely-controllable 3D viewer, built on top of three.js
MIT License
256 stars 48 forks source link

Make background color configurable #52

Closed rdeits closed 4 years ago

rdeits commented 5 years ago

It's currently hard-coded here:

https://github.com/rdeits/meshcat/blob/efc157436ca4abf5706cf248c51d2e86cae1a0f0/src/index.js#L531-L532

but it would be easy to make this configurable through the GUI.

rdeits commented 5 years ago

cc @thowell

GathererA commented 5 years ago

Hello! I've changed the top_color manually in the source code locally on my machine, but nothing changes. I'm currently using the Julia wrapper. I have tried various combinations of colors, but no set will change from lightskyblue and midnightblue. Is there something else that I should be doing to re-implement the javascript code in the Julia wrapper?

Thanks!

GathererA commented 5 years ago

Got it! The accessed hardcoded colors are not in the index.js file but rather the main.min.js file.

tkoolen commented 5 years ago

The main.min.js file is generated from the index.js file. See https://github.com/rdeits/meshcat#developing-meshcat.

RussTedrake commented 4 years ago

I believe this was resolved by #72.