search

meshcat-dev / meshcat

Remotely-controllable 3D viewer, built on top of three.js
MIT License
256 stars 48 forks source link

Import BufferGeometryUtils from three.js examples #69

Closed gizatt closed 4 years ago

gizatt commented 4 years ago

I think this is necessary -- I'm seeing an error

Uncaught TypeError: Cannot read property 'mergeBufferGeometries' of undefined
at merge_geometries (main.min.js:35)

otherwise.

This change is Reviewable

rdeits commented 4 years ago

Oh, I see--I think you're right, and this makes sense (as much as anything in javascript packaging makes sense...). Thanks for the fix!

EricCousineau-TRI commented 4 years ago

I'm not sure if this was fixed for all browser? :( https://github.com/RobotLocomotion/drake/pull/13050#pullrequestreview-400430779

Not sure what the proper fix is here. I don't think I had any stale deps (I rebuilt in Bazel, etc.).

EricCousineau-TRI commented 4 years ago

Nevermind. It seems like it's a Firefox caching thing :(