meshcat-dev / meshcat

Remotely-controllable 3D viewer, built on top of three.js
MIT License
250 stars 44 forks source link

Roll back three.js to fix camera animation issues #95

Closed rdeits closed 3 years ago

rdeits commented 3 years ago

This PR reverts threejs to 0.122 to fix the issues I was having with animation of camera properties.

Closes #87

Previously, I thought that the bad version of threejs was somewhere between 125 and 131, which didn't make sense given the release notes. However, it turned out that https://github.com/rdeits/meshcat/pull/80/files updated our requested version of three to 125, but didn't actually rebuild the bundled JS files, so we were already on a bad version but didn't know it yet. Once I figured that out, I was able to search back for a good revision. I strongly suspect the problem with 0.123 is related to the new animations property introduced in that version: https://github.com/mrdoob/three.js/releases/tag/r123 . That looks like it'll be a nice feature to play with and might help simplify the meshcat animation code, but for now I don't want to deal with it.