meshcloud / collie-hub

Curated hub with ready to use kit-modules for building landing zones with Collie CLI
https://collie.cloudfoundation.org
Apache License 2.0
30 stars 4 forks source link

Azure Bootstrap module uses deprecated azuread_service_principal attributes #95

Closed JohannesRudolph closed 9 months ago

JohannesRudolph commented 9 months ago

The azuread terraform provider is planing to deprecate some attributes, see https://github.com/hashicorp/terraform-provider-azuread/pull/1214

Together with the lax version constraint we place on the provider this means new collie users see these deprecation warnings.

╷
│ Warning: Deprecated attribute
│ 
│   on outputs.tf line 2, in output "client_id":
│    2:   value = azuread_service_principal.cloudfoundation_deploy.application_id
│ 
│ The attribute "application_id" is deprecated. Refer to the provider
│ documentation for details.
│ 
│ (and 3 more similar warnings elsewhere)
╵
╷
│ Warning: Argument is deprecated
│ 
│   with data.azuread_service_principal.msgraph,
│   on resources.deploy-spn.tf line 50, in data "azuread_service_principal" "msgraph":
│   50:   application_id = data.azuread_application_published_app_ids.well_known.result.MicrosoftGraph
│ 
│ The `application_id` property has been replaced with the `client_id`
│ property and will be removed in version 3.0 of the AzureAD provider
│ 
│ (and one more similar warning elsewhere)
╵
florianow commented 9 months ago

I fixed it for the boostrap