search

meshenger-app / meshenger-android

P2P Voice/Video phone App for local networks.
GNU General Public License v3.0
698 stars 108 forks source link

Fix initial value of front camera enabled to true #116

Closed irfanHaslanded closed 1 year ago

irfanHaslanded commented 1 year ago

The code assumes that the front camera is in use. If the settings don't match, then we perform a switch.

As such, this should be initialized to true. If not, the user setting to frontCamera false, will not work

mwarning commented 1 year ago

Can you tell me how to reproduce this issue? That makes it easier for me later to test and verify the fix. Thank you.

irfanHaslanded commented 1 year ago

Sure, you can try

  1. set the "Enable camera by default" and
  2. unset the "Use Front Camera By Default" option under expert mode in settings. Then make a call and see if it automatically chooses the rear camera.
mwarning commented 1 year ago

Looks good. I think I have mixed up front and back of a phone . :P

mwarning commented 1 year ago

I will make a release next week. Thank you for the bug fixes. :-)