search

meshery / meshery-adapter-library

Library of common functionality for Meshery Adapters
Apache License 2.0
28 stars 32 forks source link

Feature: MeshWorks and Patternfiles #34

Closed leecalcote closed 3 years ago

leecalcote commented 3 years ago

Description

New feature support of MeshWorks and Patternfiles

Signed commits

welcome[bot] commented 3 years ago

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Aisuko commented 3 years ago

@leecalcote @utkarsh-pro Could you guys write more detail about this feature?

leecalcote commented 3 years ago

@leecalcote @utkarsh-pro Could you guys write more detail about this feature?

Hi @Aisuko, yes, good request. Here we are - https://docs.google.com/document/d/1B2N78EdRiZF-yVo1-HY3syppwBBDumgMuYg6seD-AJ4/edit

kumarabd commented 3 years ago

@utkarsh-pro lets make a meshkit release to have proper versioning. We don't wanna stick to branch.

mgfeller commented 3 years ago

@utkarsh-pro out of interest: why are there 2 pb.go files (meshops.pb.go and meshops_grpc.pb.go)? They are also quite different. How was meshops_grpc.pb.go generated? Maybe Makefile needs to be adjusted?

tangledbytes commented 3 years ago

@utkarsh-pro out of interest: why are there 2 pb.go files (meshops.pb.go and meshops_grpc.pb.go)? They are also quite different. How was meshops_grpc.pb.go generated? Maybe Makefile needs to be adjusted?

@mgfeller new versions of protoc compiler spit out two files (if generating for grpc). One if the file is solely responsible for proto files serialization and deserialization while the other file contains the code for grpc (like implementing methods, interfaces etc.).

We don't have to change the makefile in my opinion, the new protoc will handle that automatically for us.

mgfeller commented 3 years ago

@utkarsh-pro out of interest: why are there 2 pb.go files (meshops.pb.go and meshops_grpc.pb.go)? They are also quite different. How was meshops_grpc.pb.go generated? Maybe Makefile needs to be adjusted?

@mgfeller new versions of protoc compiler spit out two files (if generating for grpc). One if the file is solely responsible for proto files serialization and deserialization while the other file contains the code for grpc (like implementing methods, interfaces etc.).

We don't have to change the makefile in my opinion, the new protoc will handle that automatically for us.

@utkarsh-pro thanks for the feedback. Referring to https://github.com/layer5io/meshery/pull/2454, I had to install the latest plugin according to https://grpc.io/docs/languages/go/quickstart/ (I was probably using the github version superseded by this one). I had to update the Makefile as well: protoc -I meshes/ meshes/meshops.proto --go-grpc_out=./meshes/ --go_out=./meshes/ Please have a look at https://github.com/layer5io/meshery/pull/2454

welcome[bot] commented 3 years ago

Thanks for your contribution to the Layer5 community! :tada:

Congrats!