search

meshery / meshery-adapter-library

Library of common functionality for Meshery Adapters
Apache License 2.0
28 stars 32 forks source link

[Kubernetes] Cannot ping adapters when meshery deployed in Kubernetes #39

Closed mgfeller closed 3 years ago

mgfeller commented 3 years ago

Signed-off-by: Michael Gfeller mgfeller@mgfeller.net

Description

This PR fixes https://github.com/layer5io/meshery/issues/2603

Notes for Reviewers

Let's discuss this. If ok, a couple of test should be re-run (in-cluster, outside of cluster).

Signed commits

kumarabd commented 3 years ago

@mgfeller This is already been done in meshkit - https://github.com/layer5io/meshkit/blob/master/utils/kubernetes/client.go#L15-L38. We just had to bump the version of meshkit to adapt the change.

mgfeller commented 3 years ago

@kumarabd @leecalcote ok, pitty I didn't know that earlier, used quite a few hours on that tbh

kumarabd commented 3 years ago

@mgfeller Lets add your profile to the meshkit and adapter-library PR template, so that you are not missed with any of the changes that come in. I think it was a mistake from my side that you weren't aware. We should also create a label, which says if the changes needs to be propagated right away to the components that uses meshkit/adapter-library.

kumarabd commented 3 years ago

Lets revert this change for now and work towards it? I apologise for this. It’s frustrating to me that any amount of your time isn’t optimally spent. Will make sure this doesn't happen in the future.

mgfeller commented 3 years ago

Lets revert this change for now and work towards it? I apologise for this. It’s frustrating to me that any amount of your time isn’t optimally spent. Will make sure this doesn't happen in the future.

Ok, thanks @kumarabd !