Closed jbyers19 closed 2 years ago
@alphaX86 given you recent focus on golanglint-ci, will you have a look at the failed check here?
Update: fixed the lint error via code change. Still don't know why the error didn't show up locally.
@alphaX86, I bumped golangci-lint to the latest version (v1.45) and this fixed most of the errors. However, there's still 1 error in the GitHub action. I ran the same command locally with the same version of golangci-lint
and am not seeing this error. Is there a caching issue perhaps?
Here's the command I ran locally. The only output is this warning, but no errors.
$ golangci-lint run --out-format=github-actions --exclude G306
WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive.
@alphaX86 given you recent focus on golanglint-ci, will you have a look at the failed check here?
Thanks, @leecalcote. I figured how to fix the lint issues. See the updated description for details.
Update: fixed the lint error via code change. Still don't know why the error didn't show up locally.
@alphaX86, I bumped golangci-lint to the latest version (v1.45) and this fixed most of the errors. However, there's still 1 error in the GitHub action. I ran the same command locally with the same version of
golangci-lint
and am not seeing this error. Is there a caching issue perhaps?Here's the command I ran locally. The only output is this warning, but no errors.
$ golangci-lint run --out-format=github-actions --exclude G306 WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive.
It might be due to the old config present in repo. Seems you've fixed all issues 😅 sorry I was in rest at that time. Anyway 👍
And since the golang is upgraded to 1.17 now, it's also needed that the golangci-lint must use go 1.17 instead of go 1.13 (by default in GitHub actions)
Thanks, @alphaX86. I updated the workflow with your suggestions.
@leecalcote, can this be merged now?
Thanks for your contribution to the Layer5 community! :tada:
Signed-off-by: Jared Byers j.byers@f5.com
Description
go.mod
to1.17
.replace
for the OTel modules to prevent version mismatch with other components.meshkit
tov0.5.12
instead ofv0.5.13
to avoid dependency issues introduced inv0.5.13
.v0.3.4
.go mod tidy
.Ran
go mod verify
andgo vet ./...
locally to test changes.Edit: Had to make a couple more changes to fix lint failures:
golangci-lint
tov1.45latest in the workflow.strings.Title
tocases.Title
. Tested the change locally to ensure the output would be the same:Output: strings: Nginx Service Mesh cases: Nginx Service Mesh