meshery / meshery-consul

Meshery adapter for Consul
https://docs.meshery.io
Apache License 2.0
74 stars 62 forks source link

Update to Meshery-adapter-library v0.5.2 #243

Closed leecalcote closed 2 years ago

leecalcote commented 2 years ago

Current Behavior

While updating this dependency, errors occurred.

Screenshots/Logs

meshery-consul git:(master) βœ— go get github.com/layer5io/meshery-adapter-library/adapter@v0.5.2
# github.com/layer5io/meshery-adapter-library/adapter
../go/pkg/mod/github.com/layer5io/meshery-adapter-library@v0.5.2/adapter/oam.go:194:40: not enough arguments in call to manifests.GetFromManifest
        have (string, number, manifests.Config)
        want (context.Context, string, int, manifests.Config)
../go/pkg/mod/github.com/layer5io/meshery-adapter-library@v0.5.2/adapter/oam.go:196:36: not enough arguments in call to manifests.GetFromHelm
        have (string, number, manifests.Config)
        want (context.Context, string, int, manifests.Config)
../go/pkg/mod/github.com/layer5io/meshery-adapter-library@v0.5.2/adapter/oam.go:267:40: not enough arguments in call to manifests.GetFromManifest
        have (string, number, manifests.Config)
        want (context.Context, string, int, manifests.Config)
../go/pkg/mod/github.com/layer5io/meshery-adapter-library@v0.5.2/adapter/oam.go:269:36: not enough arguments in call to manifests.GetFromHelm
        have (string, number, manifests.Config)
        want (context.Context, string, int, manifests.Config)

#


Contributor Guides and Resources

Revolyssup commented 2 years ago

@leecalcote this is due to older meshkit. Meshkit and adapter-library need to be updated together

leecalcote commented 2 years ago

Oh, I see. Ok that makes sense.