search

meshery / meshery-consul

Meshery adapter for Consul
https://docs.meshery.io
Apache License 2.0
72 stars 60 forks source link

[Sample App] Support deployment of Consul sample app #39

Open leecalcote opened 4 years ago

leecalcote commented 4 years ago

Enhancement Description Each service mesh generally has one or more associated sample applications that can be used to demonstrate the power of the given service mesh. Consul uses https://github.com/hashicorp/consul-k8s-l7-obs-guide as a sample application.

Desired Behavior The Consul adapter currently supports deploying sample applications from other service meshes. It should support the canonical Consul sample app, so that users can get the most thorough tour of Consul's features.

0xfirefist commented 4 years ago

Hey @leecalcote,

Can I take this up? This will help me getting started with adapters.

leecalcote commented 4 years ago

@kalradev that's great idea. Even higher priority than this sample app is the addition of Learn Layer5 as a sample app to be supported by the adapter for Consul. The addition of that application means that the Consul adapter will support SMI conformance testing. Let's get you going on that app.

0xfirefist commented 4 years ago

Great!! I will start with adding Learn Layer5.

leecalcote commented 4 years ago

Good deal. The Meshery adapter for Open Service Mesh and the Meshery adapter for Istio both support Learn Layer5 (SMI Conformance) and make for good references.

mgfeller commented 4 years ago

The Consul sample app requires quite a bit of additional setup. I think it would be good if the code could be refactored before that, towards the Kuma-blueprint. I'll add a couple of issues for that, but started with a set of tests (#94).