Update go version in relevent pkgs

meshery / meshery-linkerd

Meshery adapter for Linkerd

https://docs.meshery.io

Apache License 2.0

74 stars 64 forks source link

Update go version in relevent pkgs #546

Closed ShatilKhan closed 1 year ago

ShatilKhan commented 1 year ago

Description

This PR fixes #545

Notes for Reviewers

Signed commits

[X] Yes, I signed my commits.

I updated the go version from 1.19 to 1.21 in go.mod & Dockerfile

welcome[bot] commented 1 year ago

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

leecalcote commented 1 year ago

@Revolyssup will you review?

leecalcote commented 1 year ago

Running build checks

Aisuko commented 1 year ago

Running build checks

Hi @leecalcote sir. I saw many times the (E2E) multiple versions tests failed. Many of them failed because Meshery service cannot run in the Action environment. Is there anything we are missing?

Aisuko commented 1 year ago

https://github.com/meshery/meshery/issues/8768

theBeginner86 commented 1 year ago

Running build checks

Hi @leecalcote sir. I saw many times the (E2E) multiple versions tests failed. Many of them failed because Meshery service cannot run in the Action environment. Is there anything we are missing?

yes, I think we discussed this a bit on Slack. Its due to mesheryctl use of kubectl version --client --short as recently in K8s v1.28.0 --short flag has been deprecated (reference). So we need to update our use to kubectl version. Reference to slack conversation: https://layer5io.slack.com/archives/C011VPREG2Z/p1693831894773679

Aisuko commented 1 year ago

Running build checks

Hi @leecalcote sir. I saw many times the (E2E) multiple versions tests failed. Many of them failed because Meshery service cannot run in the Action environment. Is there anything we are missing?

yes, I think we discussed this a bit on Slack. Its due to mesheryctl use of kubectl version --client --short as recently in K8s v1.28.0 --short flag has been deprecated (reference). So we need to update our use to kubectl version. Reference to slack conversation: https://layer5io.slack.com/archives/C011VPREG2Z/p1693831894773679

Noticed and thanks.

ShatilKhan commented 1 year ago

Hi, is this PR good to merge?

welcome[bot] commented 1 year ago

Thanks for your contribution to the Meshery community! :tada:

Join the community, if you haven't yet and please leave a :star: star on the project. :smile: