meshery / meshery-nsm

Meshery adapter for Network Service Mesh
https://meshery.layer5.io/docs
Apache License 2.0
35 stars 34 forks source link

[Bug] Incorporate Adapter Version # at buildtime #124

Closed mgfeller closed 3 years ago

mgfeller commented 3 years ago

Enhancement Description

The version of the meshery-nsm adapter is not yet displayed in the Meshery UI when hovering over the adapter, only its name and port.

From the code, it looks as almost everything is in place, except setting the build-args VERSION and GIT_COMMITSHA in build-and-release.yml that are subsequently picked up in Dockerfile.

From the Consul adapter:

image

The adapter version is exposed in the ComponentInfo endpoint:

grpcurl --plaintext 127.0.0.1:10004 meshes.MeshService.ComponentInfo

For edge-latest, this returns

{
  "type": "adapter",
  "name": "NETWORK_SERVICE_MESH"
}

For master version running locally, this returns

{
  "type": "adapter",
  "name": "NETWORK_SERVICE_MESH",
  "version": "none",
  "gitSha": "none"
}

Additional context

See also https://github.com/meshery/meshery-adapter-library/issues/25

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.