search

meshery / meshery-nsm

Meshery adapter for Network Service Mesh
https://meshery.layer5.io/docs
Apache License 2.0
35 stars 34 forks source link

[CI] Support multi-platform Docker images #145

Closed Zanda256 closed 1 year ago

Zanda256 commented 2 years ago

Desired Behavior

Meshery users, particularly those running Docker Desktop can benefit from multi-platform images of Meshery Server.

Implementation

Refactor existing stable and edge build and release workflows to use docker-build-push actions. See https://github.com/meshery/meshery/blob/master/.github/workflows/build-and-release-dde.yml as an example.

Be aware of local binaries and their needs:

  1. layer5/kubeopenapi-json

Acceptance Tests

  1. platform: linux/amd64,linux/arm64 should both be supported.

Mockups

Contributor Guides and Resources

VaibhavMalik4187 commented 1 year ago

@leecalcote I'd like to work on this issue

leecalcote commented 1 year ago

Good deal... although, I believe this has already been completed - https://github.com/meshery/meshery-nsm/blob/master/.github/workflows/multi-platform.yaml

VaibhavMalik4187 commented 1 year ago

Good deal... although, I believe this has already been completed - https://github.com/meshery/meshery-nsm/blob/master/.github/workflows/multi-platform.yaml

Oops, I was only reading the build-and-release.yml file and thus, completely missed it. Thanks for the heads up.

So, we should close this issue then?