meshery / meshery-nsm

Meshery adapter for Network Service Mesh
https://meshery.layer5.io/docs
Apache License 2.0
39 stars 35 forks source link

Update go version in github actions workflows to 1.17 #147

Closed Zanda256 closed 1 year ago

Zanda256 commented 2 years ago

Current Behavior

Many of places in the workflows still mention go version 1.16 yet the adapters use go version 1.17

Desired Behavior

Workflows should also use go version 1.17

Implementation

Acceptance Tests

Mockups


Contributor Guides and Resources

yashtandon019 commented 1 year ago

/assign Hey @Zanda256 can you assing this to me ?

8rxn commented 1 year ago

Hey @leecalcote, I would like to work on this issue.

VaibhavMalik4187 commented 1 year ago

@leecalcote Can you please assign this to me? Thanks

leecalcote commented 1 year ago

@VaibhavMalik4187 yes, although, we're using 1.20 now. Please use this version.

VaibhavMalik4187 commented 1 year ago

@leecalcote The go version used in the workflows is defined as a secret variable. And I do not have access to those secrets. What should we do in this case?

leecalcote commented 1 year ago

I'm tagging @nebula-aac, who can offer counsel in terms of our new norm (or not) to explicitly define these versions in workflows and not in secrets any longer.

VaibhavMalik4187 commented 1 year ago

I'm tagging @nebula-aac, who can offer counsel in terms of our new norm (or not) to explicitly define these versions in workflows and not in secrets any longer.

@nebula-aac would you like to offer your assistance in this case?

leecalcote commented 1 year ago

@VaibhavMalik4187 not hearing from @nebula-aac, let's proceed with displacement of the secret with an explicit version number listed. Let's jump to 1.20

VaibhavMalik4187 commented 1 year ago

@VaibhavMalik4187 not hearing from @nebula-aac, let's proceed with displacement of the secret with an explicit version number listed. Let's jump to 1.20

On it.