meshery / meshery-nsm

Meshery adapter for Network Service Mesh
https://meshery.layer5.io/docs
Apache License 2.0
35 stars 34 forks source link

[CI] Update Multi Platform build and Release workflow #152

Closed theBeginner86 closed 1 year ago

theBeginner86 commented 1 year ago

Current Behavior

Currently, the multiplatform.yml file is sending unwanted build arguments to docker build process because of which release tag and commit_sha are not being passed over to the image and hence the version of meshery adapter are not visible on-hovering adapters chips on Meshery UI Dashboard.

Desired Behavior

This would be fixed when correct build args are passed to the docker build step inside multiplatform workfow. Required Args:

Check this commit for reference: https://github.com/meshery/meshery-consul/commit/446ad170c938c9bfe22e6e8710459d63395b9148

related to: https://github.com/meshery/meshery/issues/6245


Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

kamalbuilds commented 1 year ago

hi @theBeginner86 a devops related issue, can I pick this up :)