search

meshery / meshery-operator

Meshery Operator is a Kubernetes Operator that deploys and manages the lifecycle of two Meshery components critical to Meshery's operations of Kubernetes clusters
https://meshery.io
Apache License 2.0
111 stars 80 forks source link

Meshsync config on Meshery Operator CRD #533

Closed KiptoonKipkurui closed 1 year ago

KiptoonKipkurui commented 1 year ago

Description This PR adds Meshsync configuration information to Meshsync CRD This PR fixes #532

Notes for Reviewers

Signed commits

welcome[bot] commented 1 year ago

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9828f7c) 49.70% compared to head (a9ca7f1) 53.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #533 +/- ## ========================================== + Coverage 49.70% 53.30% +3.59% ========================================== Files 9 9 Lines 513 514 +1 ========================================== + Hits 255 274 +19 + Misses 236 221 -15 + Partials 22 19 -3 ``` | [Flag](https://app.codecov.io/gh/meshery/meshery-operator/pull/533/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/meshery/meshery-operator/pull/533/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery) | `53.30% <100.00%> (+3.59%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

welcome[bot] commented 1 year ago

        Thank you for contributing to the Layer5 community! :tada: \ \ Meshery Logo \ \         :star: Please leave a star on the project. :smile: