search

meshery / meshery-operator

Meshery Operator is a Kubernetes Operator that deploys and manages the lifecycle of two Meshery components critical to Meshery's operations of Kubernetes clusters
https://meshery.io
Apache License 2.0
111 stars 80 forks source link

Remove circular dependencies #536

Closed Aisuko closed 1 year ago

Aisuko commented 1 year ago

Description

This PR fixes #

Notes for Reviewers

Currently, meshkit import meshery-operator as a dependency https://github.com/meshery/meshkit/blob/2139daa803facbfca54860e879033b8613669773/go.mod#L22

And meshery-operator import meshkit as a dependency.

So, here is a circular dependencies. And this can be avoided and it should be avoided. It can lead to various issues, including * compilation errors

Signed commits

codecov[bot] commented 1 year ago

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (e76bb7f) 50.22% compared to head (cc4af68) 49.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #536 +/- ## ========================================== - Coverage 50.22% 49.70% -0.52% ========================================== Files 9 9 Lines 450 513 +63 ========================================== + Hits 226 255 +29 - Misses 209 236 +27 - Partials 15 22 +7 ``` | [Flag](https://app.codecov.io/gh/meshery/meshery-operator/pull/536/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/meshery/meshery-operator/pull/536/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery) | `49.70% <45.97%> (-0.52%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/meshery/meshery-operator/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery) | Coverage Δ | | |---|---|---| | [controllers/broker\_controller.go](https://app.codecov.io/gh/meshery/meshery-operator/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery#diff-Y29udHJvbGxlcnMvYnJva2VyX2NvbnRyb2xsZXIuZ28=) | `30.86% <ø> (-18.52%)` | :arrow_down: | | [controllers/error.go](https://app.codecov.io/gh/meshery/meshery-operator/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery#diff-Y29udHJvbGxlcnMvZXJyb3IuZ28=) | `100.00% <100.00%> (+75.00%)` | :arrow_up: | | [controllers/meshsync\_controller.go](https://app.codecov.io/gh/meshery/meshery-operator/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery#diff-Y29udHJvbGxlcnMvbWVzaHN5bmNfY29udHJvbGxlci5nbw==) | `50.57% <ø> (ø)` | | | [pkg/broker/error.go](https://app.codecov.io/gh/meshery/meshery-operator/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery#diff-cGtnL2Jyb2tlci9lcnJvci5nbw==) | `100.00% <100.00%> (+100.00%)` | :arrow_up: | | [pkg/broker/broker.go](https://app.codecov.io/gh/meshery/meshery-operator/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery#diff-cGtnL2Jyb2tlci9icm9rZXIuZ28=) | `49.13% <31.88%> (-25.41%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.