[CI] Update Multi Platform build and Release workflow

theBeginner86 commented 2 years ago

Current Behavior

Currently, the multiplatform.yml file is sending unwanted build arguments to docker build process because of which release tag and commit_sha are not being passed over to the image and hence the version of meshery adapter are not visible on-hovering adapters chips on Meshery UI Dashboard.

Desired Behavior

This would be fixed when correct build args are passed to the docker build step inside multiplatform workfow. Required Args:

VERSION
GIT_COMMITSHA

Check this commit for reference: https://github.com/meshery/meshery-consul/commit/446ad170c938c9bfe22e6e8710459d63395b9148

Environment

Host OS: Mac Linux Windows
Platform: Docker or Kubernetes
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Meshery Adapter Version: stable-v

Contributor Guides and Resources

📝 Meshery Adapters Spreadsheet
🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation
- Meshery documentation site and source
🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

welcome[bot] commented 2 years ago

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.

keenson commented 2 years ago

Hi @theBeginner86, Please assign this issue to me. I would like to do this.

kamalbuilds commented 2 years ago

here you go @keenson ✔️

acald-creator commented 2 years ago

This issue can be closed at this time, due to this commit https://github.com/meshery/meshery-osm/commit/0a5bc4cfefb9ddd5e828a12e0b3e51600f5ede96

meshery / meshery-osm