meshery / meshery-osm

Meshery Adapter for Open Service Mesh
https://layer5.io/meshery
Apache License 2.0
42 stars 47 forks source link

#206-Update Slack & Community logo links #207

Closed jasonjg closed 1 year ago

jasonjg commented 1 year ago

Signed-off-by: Jason Galbiso jasongcodes@gmail.com

Description

This PR fixes #206

Notes for Reviewers

The README.md Community and Slack logos had their href links switched. I updated them so that clicking on the Slack logo redirects to http://slack.layer5.io and clicking on the Community logo (3 green figures) redirects to https://meshery.io/community

Signed commits

welcome[bot] commented 1 year ago

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

leecalcote commented 1 year ago

Thank you, @jasonjg 👍

jasonjg commented 1 year ago

Can you also please fix the broken "build status" image?

I'm unable to locate badge.svg.

The link for the asset points to a directory named "workflows" in the main meshery-osm directory. However, that directory is not there, and badge.svg is not found in the meshery-osm repository.

Line 9: https://github.com/layer5io/meshery-osm/workflows/Meshery%20OSM/badge.svg

UtkarshMishra12 commented 1 year ago

@leecalcote Can you please guide him?

UtkarshMishra12 commented 1 year ago

@jasonjg Try using this Link

jasonjg commented 1 year ago

@jasonjg Try using this Link

Thanks for your guidance. I'll look more into shields.io and learn how to use it.

UtkarshMishra12 commented 1 year ago

@jasonjg Can you please signed-off your commits by following the instructions on this page? or In your local branch, run: git rebase HEAD~3 --signoff Force push your changes to overwrite the branch: git push --force-with-lease origin jasonjg/update-logo-links

welcome[bot] commented 1 year ago

Thanks for your contribution to the Layer5 community! :tada:

Congrats!         :star: Please star the project. :smile: if you have yet to do so.

leecalcote commented 1 year ago

Yay, @jasonjg! 🎈 💯