search

meshery / meshery-osm

Meshery Adapter for Open Service Mesh
https://layer5.io/meshery
Apache License 2.0
40 stars 47 forks source link

Added svg in config.yml #243

Closed Ghat0tkach closed 1 year ago

Ghat0tkach commented 1 year ago

Description

This PR fixes #235

Notes for Reviewers

Signed commits

welcome[bot] commented 1 year ago

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

ShivangShandilya commented 1 year ago

Thank you for your contribution @Ghat0tkach 😁 The changes LGTM but as you can see DCO is not passing the required check so please take a look at that 😅

Ghat0tkach commented 1 year ago

Thank you for your contribution @Ghat0tkach 😁 The changes LGTM but as you can see DCO is not passing the required check so please take a look at that 😅

I dont why im not able to do it , i have tried both by terminal as well as commiting directly using github

Ghat0tkach commented 1 year ago

I unexpectly did some errors , that why closing this req will open again with new branch