meshery / meshery-osm

Meshery Adapter for Open Service Mesh
https://layer5.io/meshery
Apache License 2.0
40 stars 47 forks source link

chore: update go version and workflow files #265

Closed ptdatta closed 1 year ago

ptdatta commented 1 year ago

Description Updated go version

This PR fixes #264

Notes for Reviewers

Signed commits

welcome[bot] commented 1 year ago

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

ptdatta commented 1 year ago

@leecalcote @theBeginner86 @saurabh100ni does I need to change actions/setup-go@master to actions/setup-go@v4. Or it automatically take the latest version??

leecalcote commented 1 year ago

Running build checks...

nebula-aac commented 1 year ago

After testing this PR,

The top portion of the go.mod needs to be this

module github.com/layer5io/meshery-osm

go 1.21

replace github.com/kudobuilder/kuttl => github.com/layer5io/kuttl v0.4.1-0.20200723152044-916f10574334

require (
    github.com/google/uuid v1.3.1
    github.com/layer5io/meshery-adapter-library v0.6.9
    github.com/layer5io/meshkit v0.6.65
    github.com/layer5io/service-mesh-performance v0.6.1
    gopkg.in/yaml.v2 v2.4.0
    k8s.io/apimachinery v0.28.2
)

but after doing this, there is indirect dep that creeped in from meshkit@v0.6.65 but this wasn't a problem in meshery-kuma: https://github.com/meshery/meshery-kuma/pull/416

# oras.land/oras-go/pkg/auth/docker
/go/pkg/mod/oras.land/oras-go@v1.2.3/pkg/auth/docker/login.go:86:39: cannot use remote (variable of type *"github.com/docker/docker/registry".Service) as "github.com/docker/docker/registry".Service value in argument to c.loginWithTLS
ptdatta commented 1 year ago

After testing this PR,

The top portion of the go.mod needs to be this

module github.com/layer5io/meshery-osm

go 1.21

replace github.com/kudobuilder/kuttl => github.com/layer5io/kuttl v0.4.1-0.20200723152044-916f10574334

require (
  github.com/google/uuid v1.3.1
  github.com/layer5io/meshery-adapter-library v0.6.9
  github.com/layer5io/meshkit v0.6.65
  github.com/layer5io/service-mesh-performance v0.6.1
  gopkg.in/yaml.v2 v2.4.0
  k8s.io/apimachinery v0.28.2
)

but after doing this, there is indirect dep that creeped in from meshkit@v0.6.65 but this wasn't a problem in meshery-kuma: meshery/meshery-kuma#416

# oras.land/oras-go/pkg/auth/docker
/go/pkg/mod/oras.land/oras-go@v1.2.3/pkg/auth/docker/login.go:86:39: cannot use remote (variable of type *"github.com/docker/docker/registry".Service) as "github.com/docker/docker/registry".Service value in argument to c.loginWithTLS

@nebula-aac Did I need to add it on top of the go.mod file?

nebula-aac commented 1 year ago

Actually, we need to cancel this PR, as this repo is supposed to be archived.