meshery / meshery.io

Website for Meshery
https://meshery.io
Apache License 2.0
506 stars 571 forks source link

Created the UI for Brand pg #1719

Closed psankhe28 closed 2 months ago

psankhe28 commented 5 months ago

Description

This PR fixes #1692

Notes for Reviewers

Signed commits

Video:

brand-pg

netlify[bot] commented 5 months ago

Deploy Preview for mesheryio-preview ready!

Name Link
Latest commit 6d62af811230f4c858e0a6224d6d49e10db2162a
Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6623cabaf2610f0008eb300a
Deploy Preview https://deploy-preview-1719--mesheryio-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 5 months ago

Deploy Preview for mesheryio-preview ready!

Name Link
Latest commit ac1ac4251119a7e52717e2f38888aef04f64999f
Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66538448c9368400086ac30d
Deploy Preview https://deploy-preview-1719--mesheryio-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

psankhe28 commented 5 months ago

@Rexford74, can you please review this?

vishalvivekm commented 5 months ago

@psankhe28 Let's discuss this on websites call today. I've added this as an agenda item to the meeting minutes. Meeting details: https://meet.layer5.io

Rexford74 commented 5 months ago

Please be sure to drop in a message on slack when you've updated the PR so that we can review this and get it merged. Well done, @psankhe28.

ritiksaxena124 commented 5 months ago

Merge conflicts @psankhe28

leecalcote commented 4 months ago

@Rexford74 ready for review.

Rexford74 commented 4 months ago

Hey, Pratiksha. Thank you your efforts on this so far. Just a little adjustments left to get this merged please if you will. I have highlighted the needed changes in a video for better understanding. Please let me know if this is clear or if you will require further clarification. Thank you. Video Link

psankhe28 commented 4 months ago

Hey, Pratiksha. Thank you your efforts on this so far. Just a little adjustments left to get this merged please if you will. I have highlighted the needed changes in a video for better understanding. Please let me know if this is clear or if you will require further clarification. Thank you. Video Link

The space is due to the layout which is used as a base for all the pages.

sudhanshutech commented 4 months ago

@psankhe28 will you share your progress in website meet if you don't have exam

psankhe28 commented 4 months ago

@psankhe28 will you share your progress in website meet if you don't have exam

I have already shown it twice and in the last meet it was decided to merge but it is not merged yet. I have my exams till 10 June so I won't be able to join.

stale[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 months ago

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.