meshery / meshery.io

Website for Meshery
https://meshery.io
Apache License 2.0
459 stars 539 forks source link

Added trademark in footer #1736

Open psankhe28 opened 1 month ago

psankhe28 commented 1 month ago

Description

This PR fixes #1622

Notes for Reviewers

Signed commits

netlify[bot] commented 1 month ago

Deploy Preview for mesheryio-preview ready!

Name Link
Latest commit 96780e9043e6a3e5d67159e06328f0d4b4c1ed26
Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6633e5977a48c70008cd7e58
Deploy Preview https://deploy-preview-1736--mesheryio-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for mesheryio-preview ready!

Name Link
Latest commit 39c77c40650112c0e2c89828dadc07445c909a8a
Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6642014cff7995000896a20e
Deploy Preview https://deploy-preview-1736--mesheryio-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vishalvivekm commented 1 month ago

Revert formatting and prettier changes, if you would. @psankhe28

vishalvivekm commented 1 month ago

@psankhe28 Let's discuss this on Websites's call. Add this as an agenda item into the meeting minutes, if you would :)

Rexford74 commented 1 month ago

Hey, Pratiksha. I've taken a look at the deployment. I think that just having the word 'Trademarks' there seems a little vague. Is it possible to have something like what is implemented here as this has been confirmed to be the desired result by the issue raiser? Then you can make the 'Trademarks Usage Page' a clickable link that leads to the usage webpage. Let me know what you think. Thanks.

psankhe28 commented 1 month ago

Hey, Pratiksha. I've taken a look at the deployment. I think that just having the word 'Trademarks' there seems a little vague. Is it possible to have something like what is implemented here as this has been confirmed to be the desired result by the issue raiser? Then you can make the 'Trademarks Usage Page' a clickable link that leads to the usage webpage. Let me know what you think. Thanks.

In the Slack channel, I inquired about which implementation to pursue, and based on the suggestions, I was advised to implement the one you can observe in the pull request.

Rexford74 commented 1 month ago

But it seems too vague. It says 'Trademarks' but doesn't specify for which solution, or that it is a disclaimer either. It just links people to the LFX usage page. I don't know that this is a better outcome than the one sampled in the initial issue. If it's possible, I'll also like to see the link to the conversation that you had on slack so that I can get a bit more insight on the conversation had. That said, in the meantime, maybe we can merge this PR to allow for traction, then when more clarity is achieved, we can make improvements where necessary.

psankhe28 commented 1 month ago

But it seems too vague. It says 'Trademarks' but doesn't specify for which solution, or that it is a disclaimer either. It just links people to the LFX usage page. I don't know that this is a better outcome than the one sampled in the initial issue. If it's possible, I'll also like to see the link to the conversation that you had on slack so that I can get a bit more insight on the conversation had. That said, in the meantime, maybe we can merge this PR to allow for traction, then when more clarity is achieved, we can make improvements where necessary.

https://layer5io.slack.com/archives/C015QJKUMPU/p1714659786470789

stale[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dragon-slayer875 commented 1 week ago

@Rexford74 @psankhe28 Do we have any updates here? :eyes:

sudhanshutech commented 1 day ago

I wonder do we require this trademark? @psankhe28 are you still following up on this pr .