search

meshery / meshery.io

Website for Meshery
https://meshery.io
Apache License 2.0
459 stars 539 forks source link

Responsive issue with main menu at 1141px #1749 #1756

Closed 26vanshika closed 2 weeks ago

26vanshika commented 1 month ago

Responsive issue with main menu at 1141px #1749

This PR fixes # The responsive issue pertaining to Safari

welcome[bot] commented 1 month ago

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

netlify[bot] commented 1 month ago

Deploy Preview for mesheryio-preview ready!

Name Link
Latest commit 7f9d531cfc6f3f13c7b7ccd6497d2a54a0573f23
Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/665cac33d3120500089f86c6
Deploy Preview https://deploy-preview-1756--mesheryio-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 month ago

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

vishalvivekm commented 1 month ago

@26vanshika Will you please sign off your commits ? Here's how you can do it: https://github.com/meshery/meshery.io/pull/1756/checks?check_run_id=25387385069

vishalvivekm commented 1 month ago

Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes.

26vanshika commented 1 month ago

@captain-Akshay I will take a look

sudhanshutech commented 1 month ago

@26vanshika any progress?

26vanshika commented 1 month ago

@sudhanshutech @vishalvivekm Could you take a look at this

Screenshot 2024-05-29 at 4 47 42 PM Screenshot 2024-05-29 at 4 48 09 PM

As you compare the styles part of both the ss we can see that @media screen and (max-width: 1140px) .nav-list { box-shadow: var(--box-shadow-primary); max-height: 250px; overflow-y: scroll; overflow-x: hidden; } this part is causing the issue i suppose, since its absence on the left side is not causing the issue.

vishalvivekm commented 3 weeks ago

@sudhanshutech @vishalvivekm Could you take a look at this

Let's discuss this on Websites's call on Monday. Please add this Adding this as an agenda item into the meeting minutes.

leecalcote commented 2 weeks ago

Thanks!

welcome[bot] commented 2 weeks ago

Thanks for your contribution to the Layer5 and Meshery community! :tada:

Meshery Logo

        :star: Please leave a star on the project. :smile:

leecalcote commented 2 weeks ago

Uh-oh... was this not completed? I thought this was done, but I seem to be mistaken. @sudhanshutech will you make an assessment and fix as needed?

vishalvivekm commented 1 week ago

Uh-oh... was this not completed? I thought this was done, but I seem to be mistaken. @sudhanshutech will you make an assessment and fix as needed?

I'll list this as agenda item and request contributors with a Mac to confirm this fix.

hargunkaur286 commented 1 week ago

Can I work on this? @vishalvivekm

vishalvivekm commented 1 week ago

Can I work on this? @vishalvivekm

sure @hargunkaur286, FYI https://github.com/meshery/meshery.io/issues/1749#issuecomment-2129298358