Closed dusdjhyeon closed 2 days ago
Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.
Name | Link |
---|---|
Latest commit | de62cc036737484576338d39ea087de188401ded |
Latest deploy log | https://app.netlify.com/sites/mesheryio-preview/deploys/667a0b5de2b7da0008eb1f29 |
Deploy Preview | https://deploy-preview-1770--mesheryio-preview.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@dusdjhyeon The API is returning responses will you recheck?
@dusdjhyeon The API is returning responses will you recheck?
Now we can get it! I modified func main a bit to fit that in. And, I also resolved something
Please handle the error using meshkit errors.
Have you tried running the workflow at your forked repo to verify if files are generated correctly? If possible, try running this workflow on your forked repo and share a link to the generated files.
An example of the artifacthub-pkg.yml obtained by running this Github Action can be found at the following link.
It has been modified to utilize Meshkit err as much as possible, and in some places it uses
if err != nil {
return err
}
in the log in main to pass in the meshkit err returned by the invoked function.
@dusdjhyeon Design versioning is now supported. Please ensure that we are not hardcoding design version here, but using the value provided by the Cloud catalog (in the same way that you are for other design properties).
I wonder if this conversion program shouldn't be under a folder named "artifact-hub-pkg" or something similar, something more descriptive than "actions". What do you think, @dusdjhyeon?
@dusdjhyeon will you confirm that if this script fails, that 1) we continue to publish designs, and @Jougan-0 will you ensure that 2) an email is sent to developers@meshery.io to ensure that the failure gets attention?
I wonder if this conversion program shouldn't be under a folder named "artifact-hub-pkg" or something similar, something more descriptive than "actions". What do you think, @dusdjhyeon?
I think artifact-hub-pkg is clear.
Thanks for your contribution to the Layer5 and Meshery community! :tada:
:star: Please leave a star on the project. :smile:
Description
This PR fixes #1764
Notes for Reviewers There are some ambiguities.
https://meshery.layer5.io//api/identity/users/profile/$userID
, but/api/catalog/content/pattern
still returnsunable to get meshery catalog patterns
(which used in fetchCatalogPatterns()).Signed commits