search

meshery / meshery.io

Website for Meshery
https://meshery.io
Apache License 2.0
517 stars 587 forks source link

Unable to download catalog item #1843

Open akshansh-modi opened 3 months ago

akshansh-modi commented 3 months ago

Description

i am unable to download catalog item , it seems to me that this is a CORS issue

Screenshots

image image image

Workaround : opening download link in another tab seems to work

Enviroment:

Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

sudhanshutech commented 3 months ago

@akshansh-modi are you willing to work on the issue?

akshansh-modi commented 3 months ago

Yes, I was looking into it since I am also working on issue #1768. This appears to be an easy one-line fix. Could you please assign it to me so I can create the PR?

akshansh-modi commented 3 months ago

@sudhanshutech, should I go ahead and create a PR?

leecalcote commented 3 months ago

@sudhanshutech, should I go ahead and create a PR?

What' fix are you proposing?

akshansh-modi commented 3 months ago

@leecalcote @sudhanshutech The current implementation uses fetch for downloading a resource, which triggers CORS issues.

Proposed Solution: To bypass the CORS issue, I suggest using an <a> tag for direct navigation to the download link. This change will allow the resource to be downloaded without encountering CORS errors as the browser will treat it as only navigation.

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.