search

meshery / meshery.io

Website for Meshery
https://meshery.io
Apache License 2.0
517 stars 588 forks source link

[UI] Next button invisible when click on #1863

Open amitamrutiya opened 3 months ago

amitamrutiya commented 3 months ago

Description

Link: Extension Page On this page, when the "Next" button is clicked, it becomes invisible.

Expected Behavior

If we choose not to use pagination, remove the "Next" and "Previous" buttons; otherwise, apply pagination.

Screenshots

Screencast from 2024-08-14 16-39-36.webm

Environment:

Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

Aviral0702 commented 2 months ago

@amitamrutiya I can reproduce the issue. You can ask for assignment and then go ahead.

abbi4code commented 2 months ago

Can i work on this issue?

Ashparshp commented 2 months ago

@amitamrutiya, @Aviral0702, we've implemented the pagination, right? The issue is that we don't have more cards to show when clicking Next. So, can we add a condition instead of removing the button?

amitamrutiya commented 2 months ago

Yeah that makes sense.

Aviral0702 commented 2 months ago

@Ashparshp Makes sense.

Ashparshp commented 2 months ago

@abbi4code, read the discussion and go accordingly. Please don't remove.

abbi4code commented 2 months ago

@Ashparshp Yeah, I got it. Instead of completely removing the 'Next' button, we can add a condition to check if there are more cards available to display. If there are more cards, the button should remain active, but if not, we can either disable the button or hide it. This way, we keep the pagination logic intact without breaking the user flow.

bhushan354 commented 1 month ago

@Ashparshp @amitamrutiya can you assign this issue to me , I have fixed the error .

stale[bot] commented 6 days ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.