Open leecalcote opened 2 years ago
Hey @leecalcote, I can work on this. Can you please explain what you mean by multiple PRs?
@tinniaru3005 this effort doesn't have to be completed in one shot.
@tinniaru3005 does this make sense?
@tinniaru3005 does this make sense?
Ya, it does. Should I get started with solving it? Is there any specification on breaking up the task that I should follow?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Hey @leecalcote can i take this task ?
Thanks, @arun-kushwaha04
@leecalcote Let me try this one now
Thanks @leecalcote
@ashutosh887 please update
is the issue solved or anyone is working on it?
@Pranjal7852 theres been no updates from @ashutosh887 so i guess he might be working on it
I already have some experience in Sass architecture , and upon looking at the repo i found the basic architecture missing as mentioned in https://sass-guidelin.es/#architecture , the 7-1 pattern Basically, we have all our partials stuffed into 7 different folders, and a single file at the root level (usually named main.scss) which imports them all to be compiled into a CSS stylesheet.
base/
components/
layout/
pages/
themes/
abstracts/
vendors/
@Pranjal7852 do you still want to work on this issue or let @Ghat0tkach take up this issue?
I still working on this issue @Savio629 cheers
@Pranjal7852, since we haven't heard back from @Pranjal7852, Reassigning this issue to myself
@sudhanshutech Can I assign myself this issue?
Hey @leecalcote ! if this issue is still open would like to work on it.
Hey @leecalcote ! I have added PR for this issue here https://github.com/meshery/meshery.io/pull/1880 by using this method we can easily remove unused CSS from the codebase without checking every file manually.
Current Behavior This site has much unused CSS and some overlapping CSS.
Desired Behavior Use of SASS is preferred. Ideally, most of the CSS (by line count) is removed from the site. This can be done piecemeal over multiple PRs.
Contributor Guides and Resources