search

meshery / meshery.io

Website for Meshery
https://meshery.io
Apache License 2.0
517 stars 588 forks source link

Website: Consolidate duplicative and unused CSS #896

Open leecalcote opened 2 years ago

leecalcote commented 2 years ago

Current Behavior This site has much unused CSS and some overlapping CSS.

Desired Behavior Use of SASS is preferred. Ideally, most of the CSS (by line count) is removed from the site. This can be done piecemeal over multiple PRs.

Contributor Guides and Resources

tinniaru3005 commented 2 years ago

Hey @leecalcote, I can work on this. Can you please explain what you mean by multiple PRs?

leecalcote commented 2 years ago

@tinniaru3005 this effort doesn't have to be completed in one shot.

leecalcote commented 2 years ago

@tinniaru3005 does this make sense?

tinniaru3005 commented 2 years ago

@tinniaru3005 does this make sense?

Ya, it does. Should I get started with solving it? Is there any specification on breaking up the task that I should follow?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

arun-kushwaha04 commented 1 year ago

Hey @leecalcote can i take this task ?

leecalcote commented 1 year ago

Thanks, @arun-kushwaha04

ashutosh887 commented 1 year ago

@leecalcote Let me try this one now

ashutosh887 commented 1 year ago

Thanks @leecalcote

DarrenDsouza7273 commented 1 year ago

@ashutosh887 please update

Pranjal7852 commented 1 year ago

is the issue solved or anyone is working on it?

DarrenDsouza7273 commented 1 year ago

@Pranjal7852 theres been no updates from @ashutosh887 so i guess he might be working on it

Ghat0tkach commented 1 year ago

I already have some experience in Sass architecture , and upon looking at the repo i found the basic architecture missing as mentioned in https://sass-guidelin.es/#architecture , the 7-1 pattern Basically, we have all our partials stuffed into 7 different folders, and a single file at the root level (usually named main.scss) which imports them all to be compiled into a CSS stylesheet.

base/ components/ layout/ pages/ themes/ abstracts/ vendors/

Savio629 commented 1 year ago

@Pranjal7852 do you still want to work on this issue or let @Ghat0tkach take up this issue?

Pranjal7852 commented 1 year ago

I still working on this issue @Savio629 cheers

thisiskaransgit commented 1 year ago

@Pranjal7852, since we haven't heard back from @Pranjal7852, Reassigning this issue to myself

Dananjay996 commented 11 months ago

@sudhanshutech Can I assign myself this issue?

THEBOSS0369 commented 3 months ago

Hey @leecalcote ! if this issue is still open would like to work on it.

THEBOSS0369 commented 2 months ago

Hey @leecalcote ! I have added PR for this issue here https://github.com/meshery/meshery.io/pull/1880 by using this method we can easily remove unused CSS from the codebase without checking every file manually.