search

meshery / meshery

Meshery, the cloud native manager
https://meshery.io
Apache License 2.0
5.66k stars 1.77k forks source link

[mesheryctl] Confirm that helm charts, not k8s manifests are used for Meshery install #10926

Open leecalcote opened 4 months ago

leecalcote commented 4 months ago

See mesheryctl Command Tracker for current status of commands.

Current Behavior

Is this old code, unused, and can be removed? https://github.com/meshery/meshery/blob/master/mesheryctl/pkg/utils/platform.go#L127

Contributor Resources

github-actions[bot] commented 4 months ago

This issue has been labeled with 'component/mesheryctl'. Note that after making changes you need to update it in the mesheryctl command tracker spreadsheet.

        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

Aryakoste commented 4 months ago

Hello @leecalcote i would like to work on this issue. We just have to check if the above given code is used in meshery install and if not remove it right ?.

leecalcote commented 4 months ago

Thank you very much, @Aryakoste. Yes, sir, that’s right.

KunyueXing commented 2 weeks ago

Hi @leecalcote, I've submitted a PR #11905 related to mesheryctl and now I've got time to take a new one. Could you please assign this issue to me?

leecalcote commented 2 weeks ago

@KunyueXing sounds good. This is a small research item. Helm should be used. You'll want to understand the behavior of files retrieved and placed under ~/.meshery/manifests. A Docs update when complete would be good.

KunyueXing commented 2 weeks ago

@leecalcote, thanks for assigning this issue to me. I appreciate the detailed instructions and will keep you updated.