meshery / meshery

Meshery, the cloud native manager
https://meshery.io
Apache License 2.0
4.97k stars 1.54k forks source link

Search cmd #10956

Open Jougan-0 opened 2 weeks ago

Jougan-0 commented 2 weeks ago

Notes for Reviewers

This PR fixes #9844

Signed commits

github-actions[bot] commented 2 weeks ago

leecalcote commented 2 weeks ago

A low priority.

When will the model import logs land? It's been many months now.

Jougan-0 commented 2 weeks ago

A low priority.

When will the model import logs land? It's been many months now.

I'll get to it I saw ripul had an open pr already had a look to it saw your comments too will start working on it . Is there anything before hand that I must be aware of @leecalcote

You are talking about this pr?

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 9.01%. Comparing base (036c67a) to head (c3d474e). Report is 40 commits behind head on master.

Files Patch % Lines
server/handlers/relationship_handlers.go 0.00% 9 Missing :warning:
mesheryctl/pkg/utils/error.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #10956 +/- ## ========================================== - Coverage 9.01% 9.01% -0.01% ========================================== Files 146 146 Lines 19258 19263 +5 ========================================== Hits 1736 1736 - Misses 17220 17225 +5 Partials 302 302 ``` | [Flag](https://app.codecov.io/gh/meshery/meshery/pull/10956/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/meshery/meshery/pull/10956/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery) | `9.01% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshery#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MUzairS15 commented 1 week ago

Ready?

Jougan-0 commented 1 week ago

Ready?

No need to add the check for case insensitive flags.