search

meshery / meshery

Meshery, the cloud native manager
https://meshery.io
Apache License 2.0
4.97k stars 1.54k forks source link

add error code monikers #10958

Closed EleisonC closed 2 weeks ago

EleisonC commented 2 weeks ago

Notes for Reviewers Add Error code monikers for Meshery server

This PR fixes #10761

Signed commits

github-actions[bot] commented 2 weeks ago

EleisonC commented 2 weeks ago

Thanks! Are these updates done after having changed the error code utility in MeshKit?

If you haven't seen the Messaging Framework and Notification Center design specification, it's a good one to peruse.

Alright I am taking a look

leecalcote commented 2 weeks ago

I updated the Meshery Docs Error Codes page with (hopefully) helpful details with regard to the combination of details - https://docs.meshery.io/reference/error-codes

leecalcote commented 2 weeks ago

@MUzairS15, as we go to enhance the format of the MeshKit Error Codes, will this format mess up anything other than the Meshery Docs error code page? Are Meshery Events v2 completely separate or do they use the same messaging framework, but with simply a different event format?

@aabidsofi19, the Notification Center will need to be updated, I assume.

EleisonC commented 2 weeks ago

I updated the Meshery Docs Error Codes page with (hopefully) helpful details with regard to the combination of details - https://docs.meshery.io/reference/error-codes

Alright I will make the changes shortly and push them thank you for the help @leecalcote

vishalvivekm commented 2 weeks ago

Hey @EleisonC , let's discuss this on today's Meshery Dev meeting at 7:30 PM IST. I am adding this as an agenda item. Please Join https://meet.layer5.io/meshery if you are available during the meet.

leecalcote commented 2 weeks ago

Given the discussion on yesterday's meeting, are we closing this PR?

leecalcote commented 2 weeks ago

Let me know if this is to be reopened...