search

meshery / meshery

Meshery, the cloud native manager
https://meshery.io
Apache License 2.0
4.97k stars 1.54k forks source link

[mesheryctl] Bug fixes in `mesheryctl system start` #10961

Closed MUzairS15 closed 2 weeks ago

MUzairS15 commented 2 weeks ago

Notes for Reviewers

This PR fixes #

  1. mesheryctl system start command is run using the MESHERY_SERVER_CALLBACK_URL env var, the variable is not set inside the container.
  2. When using port-forward flag, a random port is chosen on the host device, and traffic is then directed to the server within the Pod. This presents challenges in specifying a custom value for MESHERY_SERVER_CALLBACK_URL, as this value must be provided at server startup. The PR ensures that whatever value is assigned to the environment variable, the port-forward will correctly forward to the corresponding value of the environment variable <host:port>.

Signed commits

github-actions[bot] commented 2 weeks ago

MUzairS15 commented 2 weeks ago

When used with docker, it just skips the protforward logic and directly opens the browser at endpoint as specified in mesheryctl context.

Screenshot 2024-05-17 at 8 50 36 PM

// @Jougan-0 You can quickly update, to add a warning message stating the flag is for when meshery is deployed on kubernetes platform before continuing to open the browser.