search

meshery / meshery

Meshery, the cloud native manager
https://meshery.io
Apache License 2.0
5.98k stars 1.84k forks source link

Istio Error Code while uninstalling Linkerd service mesg #7004

Open bluedog13 opened 1 year ago

bluedog13 commented 1 year ago

Current Behavior

I get 1003 error code when trying to uninstall Linkerd service mesh. I don't have Istio service mesh installed in my cluster.

Expected Behavior

1003 Error code is related to Istio. Also the error code description is not helpful at all to troubleshoot.

Should we not be getting Linkerd related error code? Screenshot 2023-02-03 at 5 44 52 PM

Screenshots/Logs

Screenshot 2023-02-03 at 5 44 15 PM

Environment

Contributor Guides and Handbook

leecalcote commented 1 year ago

Yikes, this is a bit of a UX problem. While the numerical portion of error codes are allowed to overlap between Meshery components, the combination of the "\<component moniker> + \<code number>". The error codes presented in Meshery UI’s notification center only carry the numeric portion of the error code and don’t include the component moniker, leading users to believe that 1003 (in this case) is globally unique, when error codes are actually component-scoped (background info here, if interested). Meshery UI should include display of the "\<moniker> + \<code>”.

In this particular case, failure installing Linkerd, which according to the end-to-end test results for Meshery Adapter for Linkerd v0.6.6 shouldn’t be. The meshery-linkerd-1003 error code has no probable cause and no suggested remediation, however.

Thank you for highlighting this issue, @bluedog13. It looks like there are a few items to attend to here.

acald-creator commented 1 year ago

I'm working on the Linkered error code for 1003 as there are no probable cause, no suggested remediation, and no short/long description as well, I believe.

leecalcote commented 1 year ago

Tagging related the issue here - https://github.com/meshery/meshery-linkerd/issues/471

nebula-aac commented 1 year ago

Thanks for the reminder, working on this.

sandramsc commented 9 months ago

Hi @nebula-aac @acald-creator are you still intend to work on this issue? Let us know so we know to allow you more time, otherwise, we'll need to free (unassign you) the issue so as to allow other contributors to give it a go.