meshery / meshkit

Common microservices framework for Meshery components
Apache License 2.0
100 stars 91 forks source link

[feature] Migrate logrus to slog #258

Open acald-creator opened 1 year ago

acald-creator commented 1 year ago

UPDATE: slog is currently available in Go 1.21, and we should make the effort to migrate to use slog.

Current Behavior

meshkit uses logrus for custom logging, and we created a custom logger that only returns certain fields such as

But we're lacking on the other fields that logrus has and we're using a mixture of logrus and our custom logger.

meshkit will benefit from having more fields to call from, when utilizing the custom logging tool in meshery. This will help migrate mesheryctl to use the custom logger, instead of calling logrus directly.

For this purpose of tracking the migration, we will be migrating to use slog instead, which is slightly basic but gives us a bit more ability to customize logging and use more fields.

Here are the fields that slog currently supports

There is no built-in support for formatting strings, but slog allows us to create our own fields.

Desired Behavior

Opening this issue to track the progress.


Resources

Alternatives / Additional Context

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

acald-creator commented 1 year ago

bump

acald-creator commented 1 year ago

working on the logging part now

github-actions[bot] commented 9 months ago

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

ayushrakesh commented 3 months ago

@acald-creator Is this issue still open?