meshery / meshkit

Common microservices framework for Meshery components
Apache License 2.0
96 stars 86 forks source link

[Chore] Golang Test Failure: Compose #447

Open leecalcote opened 8 months ago

leecalcote commented 8 months ago

Description make go fails with the following error:

# github.com/kubernetes/kompose/pkg/transformer/kubernetes
../go/bin/pkg/mod/github.com/meshery/kompose@v1.0.1/pkg/transformer/kubernetes/kubernetes.go:583:15: cannot use api.ResourceRequirements{…} (value of type "k8s.io/api/core/v1".ResourceRequirements) as "k8s.io/api/core/v1".VolumeResourceRequirements value in struct literal

Expected Behavior All go test tests pass.


Contributor Guides and Handbook

MonalikaPatnaik commented 7 months ago

In my machine, running the command make go gives this-- m2c -o go -e go go.mod /bin/bash: line 1: m2c: command not found make: *** [<builtin>: go] Error 127 Could you elaborate the steps to reproduce this error?

ayushrakesh commented 2 months ago

@leecalcote I am interested to work in this issue.

leecalcote commented 2 months ago

Thanks much for jumping in and volunteering. I missed the prior notifications. Here's what helps guarantee both your success and assignment of the issue (and there are plenty more where this issue comes from):

Confirm that you're able to build the project, specifically, the components necessary to resolve this issue. Confirm the approach you intend to take to resolve the issue.

ayushrakesh commented 2 months ago

@leecalcote make go command is not right? Is is make test for running test? If yes, then I am not getting error on my side.

ayushrakesh commented 2 months ago

@leecalcote I want some more explanation about this issue, please help.