meshery / meshkit

Common microservices framework for Meshery components
Apache License 2.0
112 stars 95 forks source link

peform helm dry run based on the k8s model available in the registry #574

Closed MUzairS15 closed 3 months ago

MUzairS15 commented 3 months ago

Description

This PR fixes # During the import of helm charts, they are converted into k8s manifests by performing a dry run (w.o involving Kubernetes API server). The charts might have certain constraints for the Kubernetes version; accordingly, templates are converted.

For charts which do not specify the kubeversion, instead of hardcoding to v1.29.2 (playground k8s cluster version), it will be better to perform the dry run based on the highest version of the Kubernetes model available in the registry.

This ensures if the helm chart is imported successfully, the meshery server can also perform lifecycle operations. Hardcoding to a specific version may result in Helm Chart import being successful but because the meshery server doesn't have the required K8s components it might lead to failures when performing lifecycle operations.

Notes for Reviewers

Signed commits