Fix #575: Replaced deprecated utils.Unmarshal and removed unused variables

meshery / meshkit

Common microservices framework for Meshery components

Apache License 2.0

112 stars 95 forks source link

Fix #575: Replaced deprecated utils.Unmarshal and removed unused variables #579

Open ShivanshuGupta07 opened 2 months ago

ShivanshuGupta07 commented 2 months ago

Description

This PR fixes #575 by replacing deprecated utils.Unmarshal with json.Unmarshal and removing unused variables from the codebase.

Notes for Reviewers

The changes involve updates to two specific files: config/provider/inmem.go and utils/kubernetes/crd.go.
Please verify that the replacement of utils.Unmarshal does not impact any other parts of the code that may rely on its specific behavior.

Signed commits

[x] Yes, I signed my commits.

welcome[bot] commented 2 months ago

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

leecalcote commented 2 months ago

Thank you, @ShivanshuGupta07!

MUzairS15 commented 2 months ago

@ShivanshuGupta07 merge conflicts

ShivanshuGupta07 commented 1 month ago

@MUzairS15, so no changes are required now?

stale[bot] commented 1 week ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.