meshery / play

Cloud Native Playground for Kubernetes and all CNCF projects
https://play.meshery.io
Apache License 2.0
91 stars 90 forks source link

sign up button disappears when successfully signed up #108

Closed HetviSoni closed 1 year ago

HetviSoni commented 1 year ago

Notes for Reviewers

This PR fixes #105 I have added a handleSignUpFormSubmit function in the parent component of Navigation and SignupForm (ie App) which handles the appearance/disappearance of the signup button in the header.

https://github.com/meshery/play/assets/76479104/2f9797a0-e1b4-4790-83cf-d54c4347296e

Signed commits

netlify[bot] commented 1 year ago

Deploy Preview for meshery-play ready!

Name Link
Latest commit 87b380a2663975b202749e47091e0e9d97fb382a
Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/64a11fdceef8de0008594fe4
Deploy Preview https://deploy-preview-108--meshery-play.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thisiskaransgit commented 1 year ago

@HetviSoni The change is working as intended, resolve the merge conflicts and we are good to go

HetviSoni commented 1 year ago

@HetviSoni The change is working as intended, resolve the merge conflicts and we are good to go

Done

leecalcote commented 1 year ago

Uh-oh, we have a merge conflict, @HetviSoni. Will you address this, please?

@Savio629 will you give this a review, too?

HetviSoni commented 1 year ago

Uh-oh, we have a merge conflict, @HetviSoni. Will you address this, please?

@Savio629 will you give this a review, too?

Resolved👍

leecalcote commented 1 year ago

Uh-oh, a merge conflict has popped up

HetviSoni commented 1 year ago

Uh-oh, a merge conflict has popped up

Resolved👍 :)

HetviSoni commented 1 year ago

This pr has been open for a while now. It would be helpful if is merged or if any other changes are required, please suggest @leecalcote @Savio629 @thisiskaransgit